[BE] SISC1-179 [TEST] attendance controller test 코드 구현 by ochanhyeok · Pull Request #58 · SISC-IT/sisc-web

ochanhyeok · 2025-10-15T06:40:08Z

Summary by CodeRabbit

New Features
- 출석 세션을 활성화하면 시작 시간이 즉시 기록되어 세션 진행 상태와 통계가 더 정확하게 표시됩니다.
Bug Fixes
- 세션 활성화 시점의 시간 반영 누락을 보완해 시간 기반 목록/조회의 일관성을 개선했습니다.
- 일부 안내 로그 문구의 오탈자를 수정했습니다.
Refactor
- 내부 사용자 식별 흐름을 ID 기반으로 정리해 관련 처리의 일관성·안정성을 높였습니다.
Tests
- 출석 및 출석세션 관련 엔드포인트의 권한·검증·응답 형식 테스트를 대폭 추가해 신뢰성을 강화했습니다.

- 세션 CRUD 기능 테스트 - 권한별 접근 제어 검증 - 유효성 검증 및 예외 상황 테스트

coderabbitai · 2025-10-15T06:40:32Z

Walkthrough

컨트롤러는 User 객체 대신 UUID(userId/adminId)를 서비스에 전달하도록 변경되었고, 서비스는 전달된 UUID로 UserRepository에서 사용자/관리자를 조회하도록 수정되었습니다. 세션 활성화 시 startsAt을 현재 시각으로 설정하는 로직이 추가되었고, 컨트롤러용 WebMvcTest와 테스트 전용 보안 설정이 추가되었습니다.

Changes

Cohort / File(s)	Change Summary
컨트롤러: 사용자 ID 기반 호출로 전환 `backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceController.java`	Service 호출에서 User 객체 대신 UUID(userId/adminId) 전달로 변경. 내부 helper(`convertToUser`) 제거 및 관련 import 삭제.
컨트롤러: 로그/임포트 정정 `backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceSessionController.java`	불필요 import 제거 및 로그 한글 오탈자 수정(조회/종료 메시지). 시그니처/비즈니스 로직 변화 없음.
서비스: UUID 기반 사용자 조회 도입 및 시그니처 변경 `backend/src/main/java/org/sejongisc/backend/attendance/service/AttendanceService.java`	UserRepository 주입 추가. checkIn/getAttendancesByUser/updateAttendanceStatus 등에서 User/User admin을 직접 받지 않고 UUID를 받아 repository에서 조회하여 처리하도록 변경. getAttendanceBySession → getAttendancesBySession로 명칭 변경. 예외·로그 메시지 UUID 기반으로 갱신.
서비스: 세션 활성화 시 startsAt 설정 추가 `backend/src/main/java/org/sejongisc/backend/attendance/service/AttendanceSessionService.java`	activateSession에서 startsAt을 LocalDateTime.now()로 설정하도록 추가. 주석/포맷 소소한 정리.
테스트: AttendanceController WebMvcTest 추가 `backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java`	출석 체크, 본인 출석 조회, 세션별 출석(권한 포함), 상태 업데이트(성공/권한 실패) 등 MockMvc 기반 테스트 클래스 추가.
테스트: AttendanceSessionController WebMvcTest 추가 `backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java`	세션 생성/조회/활성화/종료/삭제/상태별 조회 및 권한/검증 실패 케이스 등 MockMvc 기반 테스트 클래스 추가.
테스트: 테스트 전용 보안 설정 추가 `backend/src/test/java/org/sejongisc/backend/attendance/controller/TestSecurityConfig.java`	테스트용 SecurityFilterChain 빈 추가. 특정 출석/세션 엔드포인트에 ROLE(PRESIDENT/VICE_PRESIDENT) 제한을 적용하고 나머지 요청은 인증 요구.
테스트: 서비스 단위 테스트 시그니처 대응 `backend/src/test/java/org/sejongisc/backend/attendance/service/AttendanceServiceTest.java`	AttendanceService 공개 API 변경에 맞춰 테스트 업데이트(모의 UserRepository, UUID 전달, 메서드명 변경).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User as 인증된 사용자
  participant C as AttendanceController
  participant S as AttendanceService
  participant UR as UserRepository

  User->>C: POST /attendance/sessions/{sessionId}/check-in
  C->>S: checkIn(sessionId, request, userId)
  S->>UR: findById(userId)
  UR-->>S: User (또는 empty)
  alt User 존재
    S-->>C: AttendanceResponse
    C-->>User: 200 OK + body
  else User 미존재
    S-->>C: throw NotFound
    C-->>User: 4xx/5xx 에러
  end

sequenceDiagram
  autonumber
  actor Admin as 관리자
  participant C as AttendanceController
  participant S as AttendanceService
  participant UR as UserRepository

  Admin->>C: PATCH /attendance/sessions/{sessionId}/members/{memberId}
  C->>S: updateAttendanceStatus(sessionId, memberId, status, reason, adminId)
  S->>UR: findById(adminId)
  UR-->>S: Admin User
  S-->>C: AttendanceResponse
  C-->>Admin: 200 OK

sequenceDiagram
  autonumber
  actor Admin as 관리자
  participant SC as AttendanceSessionController
  participant SS as AttendanceSessionService

  Admin->>SC: POST /attendance/sessions/{id}/activate
  SC->>SS: activateSession(id)
  SS->>SS: set startsAt = now()
  SS-->>SC: SessionResponse
  SC-->>Admin: 200 OK

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

[BE] SISC-162 [FEAT] Attendance 엔티티 User 연관관계 및 Repository, controller, DTO 구현, test 코드 작성 #38: 동일 코드 영역에서 User → UUID 전환 및 getAttendanceBySession → getAttendancesBySession 명칭 변경을 다룬 PR로 직접적 연관이 있음.

Suggested reviewers

discipline24

Poem

깡총, 토끼가 말하네: UUID로 점프했지, 빛나는 길!
User 대신 ID 한 알, 길 잃지 않겠네 🐇
활성화되면 now로 똑딱—세션 깨어나고,
테스트로 단단히 둘러싼 안전한 뜰,
출석 체크 끝! 당근은 다음 커밋에 📯🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	제목은 PR의 핵심인 AttendanceController 테스트 코드 구현을 명확히 반영하여 변경 사항과 일치합니다.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch SISC1-179-BE-AttendanceControllerTest-코드-작성

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 5

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc64935 and e7766de.

📒 Files selected for processing (7)

backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceController.java (4 hunks)
backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceSessionController.java (2 hunks)
backend/src/main/java/org/sejongisc/backend/attendance/service/AttendanceService.java (7 hunks)
backend/src/main/java/org/sejongisc/backend/attendance/service/AttendanceSessionService.java (4 hunks)
backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java (1 hunks)
backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java (1 hunks)
backend/src/test/java/org/sejongisc/backend/attendance/controller/TestSecurityConfig.java (1 hunks)

🧰 Additional context used

🪛 GitHub Actions: Backend-CI

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java

[error] 90-90: incompatible types: T has incompatible bounds; when(attendanceService.checkIn(any(UUID.class), any(AttendanceRequest.class), any(User.class)))

[error] 171-171: incompatible types: T has incompatible bounds; when(attendanceService.getAttendancesByUser(any(User.class)))

[error] 211-211: cannot find symbol: method getAttendanceBySession(UUID) in AttendanceService

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java

...c/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7766de and 0fa7327.

📒 Files selected for processing (4)

backend/src/main/java/org/sejongisc/backend/attendance/controller/AttendanceController.java (4 hunks)
backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java (1 hunks)
backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java (1 hunks)
backend/src/test/java/org/sejongisc/backend/attendance/service/AttendanceServiceTest.java (9 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java (1)

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java (1)

WebMvcTest (32-429)

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java (1)

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java (1)

WebMvcTest (40-310)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Backend Gate

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java

github-actions · 2025-10-15T07:19:27Z

⚠️ No diff coverage results

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java (1)
230-230: 메서드 이름 오타 수정

메서드 이름에 불필요한 't'가 포함되어 있습니다. getActivateSessions_success를 getActiveSessions_success로 수정하여 일관성을 유지하세요.
-    void getActivateSessions_success() throws Exception {
+    void getActiveSessions_success() throws Exception {

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fa7327 and 0ccc9a0.

📒 Files selected for processing (1)

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java (1)

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java (1)

WebMvcTest (40-310)

🔇 Additional comments (1)

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java (1)

1-44: 테스트 구조가 잘 설계되어 있습니다

테스트 클래스가 다음과 같이 올바르게 구성되어 있습니다:

@WebMvcTest를 사용한 적절한 슬라이스 테스팅

@Import(TestSecurityConfig.class)를 통한 보안 설정

@MockitoBean을 통한 서비스 계층 모킹

주요 엔드포인트에 대한 포괄적인 테스트 커버리지

...c/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java

discipline24

고생하셨습니다~

backend/src/main/java/org/sejongisc/backend/attendance/service/AttendanceService.java

ochanhyeok added 6 commits October 11, 2025 16:30

SISC1-179: TestSecurityConfig 작성

ef30322

AttendanceControllerTest코드 작성, TestSecurityConfig 수정

1a4ec15

Merge branch 'main' into SISC1-179-BE-AttendanceControllerTest-코드-작성

979fb32

수정: AttendanceController 및 AttendanceSessionController 코드 품질 개선. 수정

6b3be8e

Merge branch 'main' into SISC1-179-BE-AttendanceControllerTest-코드-작성

501ed60

test: AttendanceSessionController 테스트 코드 작성

e7766de

- 세션 CRUD 기능 테스트 - 권한별 접근 제어 검증 - 유효성 검증 및 예외 상황 테스트

ochanhyeok requested a review from discipline24 as a code owner October 15, 2025 06:40

coderabbitai bot reviewed Oct 15, 2025

View reviewed changes

[BE] SISC1-179 [TEST] 코드 리뷰 피드백 반영, 테스트 메서드명 및 검증 로직 개선

0fa7327

coderabbitai bot reviewed Oct 15, 2025

View reviewed changes

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java Show resolved Hide resolved

backend/src/test/java/org/sejongisc/backend/attendance/controller/AttendanceControllerTest.java Show resolved Hide resolved

[BE] SISC1-179 [TEST] 코드 리뷰 피드백 반영

0ccc9a0

coderabbitai bot reviewed Oct 15, 2025

View reviewed changes

...c/test/java/org/sejongisc/backend/attendance/controller/AttendanceSessionControllerTest.java Show resolved Hide resolved

discipline24 previously approved these changes Oct 15, 2025

View reviewed changes

otter2023 previously approved these changes Oct 16, 2025

View reviewed changes

Merge branch 'main' into SISC1-179-BE-AttendanceControllerTest-코드-작성

4021e2b

ochanhyeok dismissed stale reviews from otter2023 and discipline24 via 4021e2b October 16, 2025 11:07

ochanhyeok changed the title ~~[BE] SISC1-179 attendance controller test 코드 구현~~ [BE] SISC1-179 [TEST] attendance controller test 코드 구현 Oct 16, 2025

discipline24 approved these changes Oct 16, 2025 •

edited

Loading

View reviewed changes

discipline24 previously approved these changes Oct 16, 2025

View reviewed changes

discipline24 reviewed Oct 16, 2025

View reviewed changes

backend/src/main/java/org/sejongisc/backend/attendance/service/AttendanceService.java Show resolved Hide resolved

otter2023 previously approved these changes Oct 26, 2025

View reviewed changes

Merge branch 'main' into SISC1-179-BE-AttendanceControllerTest-코드-작성

d02a75d

discipline24 dismissed stale reviews from otter2023 and themself via d02a75d October 28, 2025 01:02

Merge branch 'main' into SISC1-179-BE-AttendanceControllerTest-코드-작성

2cb3d10

discipline24 merged commit 7f9c318 into main Oct 29, 2025
2 checks passed

discipline24 deleted the SISC1-179-BE-AttendanceControllerTest-코드-작성 branch October 29, 2025 05:15

coderabbitai bot mentioned this pull request Nov 2, 2025

[BE] SISC1-201 [DOCS] Swagger 고도화 - API 응답 형식 정의 #76

Merged

coderabbitai bot mentioned this pull request Nov 12, 2025

#92 [BE] SISC1-204 [FEAT] 출석 세션 기능 개선 #97

Merged

This was referenced Nov 23, 2025

[BE] SISC1 220 api 응답 개선 #133

Merged

Revert "[BE] SISC1-223 [FIX] 출석 세션 시간 변수 수정" #141

Merged

Revert "[BE] SISC1-224 [FIX] 출석 라운드 관련 수정" #144

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BE] SISC1-179 [TEST] attendance controller test 코드 구현#58

Hidden character warning

[BE] SISC1-179 [TEST] attendance controller test 코드 구현#58
discipline24 merged 11 commits intomainfrom
SISC1-179-BE-AttendanceControllerTest-코드-작성

ochanhyeok commented Oct 15, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

discipline24 left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ochanhyeok commented Oct 15, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

discipline24 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ochanhyeok commented Oct 15, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 15, 2025 •

edited

Loading

github-actions bot commented Oct 15, 2025 •

edited

Loading